Skip to content

linux_xanmod, linux_xanmod_latest: 2025-01-17#374627

Closed
Shawn8901 wants to merge 2 commits intoNixOS:masterfrom
Shawn8901:update-xanmod
Closed

linux_xanmod, linux_xanmod_latest: 2025-01-17#374627
Shawn8901 wants to merge 2 commits intoNixOS:masterfrom
Shawn8901:update-xanmod

Conversation

@Shawn8901
Copy link
Contributor

@Shawn8901 Shawn8901 commented Jan 17, 2025

https://dl.xanmod.org/changelog/6.12/ChangeLog-6.12.10-xanmod1.gz
https://dl.xanmod.org/changelog/6.6/ChangeLog-6.6.72-xanmod1.gz

i'll assign the backport label, tho that will fail due to 6.6.70 not being backported (as it was not bulidable on our stable branch (which was the issue that 6.6.71 was released, tho xanmod never didnot rlease that)) [ref https://github.com//pull/373154]

still building lts on my end
lts lgtm

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Shawn8901
Copy link
Contributor Author

Shawn8901 commented Jan 17, 2025

cc @Atemu that should hopefully then unbreak the compilation on stable, do you mind checking that? Or should i give a try to compile that on one of my server machines running on stable (will then take quite some time and maybe not work at all, as they are not very powerful)

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 17, 2025
@Shawn8901 Shawn8901 marked this pull request as ready for review January 17, 2025 21:07
@Atemu
Copy link
Member

Atemu commented Jan 18, 2025

If it runs fine on unstable, I usually just run the test to see that basic functionality works. I have never booted xanmod on a stable system.

@Shawn8901
Copy link
Contributor Author

Ah okay, i thought that you are running that after the backport commits, tho i could have just checked 🙂

Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main LGTM

@eljamm eljamm added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 22, 2025
Copy link
Contributor

@moni-dz moni-dz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main

@eljamm eljamm added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 23, 2025
@Shawn8901
Copy link
Contributor Author

closing, as there are new kernels available and LTS is replaced by a 6.12 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants