cargo-expand: use fetchCargoVendor#374508
Closed
Liamolucko wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
`cargo-expand` is currently broken on macOS due to rust-lang/cargo#13662. It's now using bat 0.25, which has a directory src/syntax_mapping/builtins/macos that's only kept around by a `.gitkeep` file, and when that's left out it causes the build to fail while attempting to open the directory. `fetchCargoVendor` doesn't have that bug, so using it instead of the default fetcher works around the problem.
github-actions
bot
added
10.rebuild-darwin: 1-10
Member
|
Done on staging in #376038. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo-expandis currently broken on macOS due to rust-lang/cargo#13662. It's now using bat 0.25, which has a directorysrc/syntax_mapping/builtins/macos that's only kept around by a
.gitkeepfile, and when that's left out it causes the build to fail while attempting to open the directory.fetchCargoVendordoesn't have that bug, so using it instead of the default fetcher works around the problem.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.