Skip to content

vscodium: fix bundle resources being modified on darwin#373630

Merged
bobby285271 merged 1 commit intoNixOS:masterfrom
andre4ik3:vscodium-darwin-fix
Jan 19, 2025
Merged

vscodium: fix bundle resources being modified on darwin#373630
bobby285271 merged 1 commit intoNixOS:masterfrom
andre4ik3:vscodium-darwin-fix

Conversation

@andre4ik3
Copy link
Contributor

Fixes #320494 by applying the same fix as in vscode to vscodium as well.

Things done

Tested bundle resources aren't modified anymore:

❯ nix build .#vscodium

❯ codesign -dvv result/Applications/VSCodium.app
Executable=/nix/store/ayymbdi0vgizlcks8v7lik5jfybkl86p-vscodium-1.96.2.24355/Applications/VSCodium.app/Contents/MacOS/Electron
Identifier=com.vscodium
Format=app bundle with Mach-O thin (arm64)
CodeDirectory v=20500 size=760 flags=0x10000(runtime) hashes=13+7 location=embedded
Signature size=9052
Authority=Developer ID Application: Baptiste Augrain (VC39D2VNQ7)
Authority=Developer ID Certification Authority
Authority=Apple Root CA
Timestamp=20 Dec 2024 at 22:26:52
Notarization Ticket=stapled
Info.plist entries=35
TeamIdentifier=VC39D2VNQ7
Runtime Version=14.0.0
Sealed Resources version=2 rules=13 files=2098
Internal requirements count=1 size=172

❯ codesign -vv result/Applications/VSCodium.app
result/Applications/VSCodium.app: valid on disk
result/Applications/VSCodium.app: satisfies its Designated Requirement
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 14, 2025
@github-actions github-actions bot added 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 14, 2025
Copy link
Member

@DimitarNestorov DimitarNestorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 14, 2025
@bobby285271 bobby285271 merged commit baad866 into NixOS:master Jan 19, 2025
25 of 27 checks passed
@bobby285271
Copy link
Member

bobby285271 commented Jan 19, 2025

Thanks (I can't test on darwin so I am trusting the testing here)

@andre4ik3 andre4ik3 deleted the vscodium-darwin-fix branch January 19, 2025 16:59
@camilosampedro camilosampedro mentioned this pull request Feb 4, 2025
13 tasks
@andre4ik3 andre4ik3 restored the vscodium-darwin-fix branch April 8, 2025 10:45
@andre4ik3 andre4ik3 deleted the vscodium-darwin-fix branch April 8, 2025 10:49
@andre4ik3 andre4ik3 restored the vscodium-darwin-fix branch April 8, 2025 10:49
@andre4ik3 andre4ik3 deleted the vscodium-darwin-fix branch April 8, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSCodium broken on MacOS

4 participants