OVMF: add passthru.mergedFirmware parameter; xen: use the merged OVMF blob#373560
OVMF: add passthru.mergedFirmware parameter; xen: use the merged OVMF blob#373560adamcstephens merged 2 commits intoNixOS:masterfrom
passthru.mergedFirmware parameter; xen: use the merged OVMF blob#373560Conversation
This is the final firmware blob that's expected by hypervisors, like Xen. The `passthru.firmware` attribute refers to the OVMF_CODE.fd blob, which is not aligned properly and exceeds the BIOS boundaries set by Xen. See NixOS#373416 and https://www.mail-archive.com/xen-devel@lists.xen.org/msg118481.html Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
|
A question: since |
Fixes NixOS#373416 Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
d0c126c to
a35e5e5
Compare
I couldn't find any official documentation on qemu's site for working with OVMF, but it obviously works as configured. As I understand it the split is to provide the CODE/fw as read-only, but allow for a separate VARS location for read-write state. If you combine them, this could in theory reduce security as the boot code could be modified by the VM in read-write mode. I wasn't aware until this Xen issue that there was even a combined version. Maybe other hypervisors care as well, but qemu doesn't consider the separated files "wrong". |
|
Unrelated to this PR: is there a thought to move the |
I don't think we can, because we need the generic builder in order to build variants of Xen, like the one in #341429. We would need to have |
|
It's against by-name rules (and the CI checks) to reference across packages in by-name. You could probably move the builder to |
Fixes #373416
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.