Skip to content

Irods fix#373470

Closed
bzizou wants to merge 2 commits intoNixOS:masterfrom
bzizou:irods-fix
Closed

Irods fix#373470
bzizou wants to merge 2 commits intoNixOS:masterfrom
bzizou:irods-fix

Conversation

@bzizou
Copy link
Contributor

@bzizou bzizou commented Jan 13, 2025

Fix #370452

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bzizou bzizou mentioned this pull request Jan 13, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 13, 2025
@bzizou
Copy link
Contributor Author

bzizou commented Jan 24, 2025

Darwin tests seems to lock this PR for weeks? Is there a way to cancel, or reload, or do something for that?

@FliegendeWurst
Copy link
Member

The ofborg Darwin build is non-blocking.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373470


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • irods
  • irods-icommands

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 5, 2025
@emilazy
Copy link
Member

emilazy commented Aug 18, 2025

Sorry this PR languished, I missed the notification!

Could you take a look at #434776? It builds successfully for me and should solve #370452 as well.

@trel
Copy link

trel commented Sep 5, 2025

#434776 is merged - so i think this can be closed now without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: irods

5 participants