Skip to content

firecracker: 1.9.1 -> 1.10.1#373359

Merged
misuzu merged 1 commit intoNixOS:masterfrom
usertam:patch/firecracker
Jan 15, 2025
Merged

firecracker: 1.9.1 -> 1.10.1#373359
misuzu merged 1 commit intoNixOS:masterfrom
usertam:patch/firecracker

Conversation

@usertam
Copy link
Member

@usertam usertam commented Jan 13, 2025

Simple version update and I reworked the aws-lc-sys deps. Should be less hacky than the last.

Hopefully using rustPlatform.fetchCargoVendor will make auto-updates easier. I see it is already in nix-update?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 13, 2025
@usertam usertam added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jan 13, 2025
@usertam
Copy link
Member Author

usertam commented Jan 13, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373359


x86_64-linux

✅ 2 packages built:
  • firecracker
  • flintlock

@techknowlogick
Copy link
Member

Thanks @usertam, could you nixfmt this as well?

@usertam
Copy link
Member Author

usertam commented Jan 13, 2025

Thanks @usertam, could you nixfmt this as well?

It will turn

cargoTestFlags = [ "--package" "firecracker" "--package" "jailer" ];

into

cargoTestFlags = [
  "--package"
  "firecracker"
  "--package"
  "jailer"
];

which looks kinda off... 😬 Do I still do it?

@techknowlogick
Copy link
Member

which looks kinda off... 😬 Do I still do it?

I agree, it doesn't look the best. I'm not sure if passing nixfmt is mandatory at this point, so if it isn't, then leaving as-is is probably fine.

Either way, this bump/your changes work pass my testing too, so I'll give this a +1 from me, and await feedback from someone who knows more about nixfmt requirements.

@techknowlogick techknowlogick added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 13, 2025
@misuzu misuzu merged commit 12b2aaf into NixOS:master Jan 15, 2025
38 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants