Merged
Conversation
Member
Author
|
Member
|
Thanks @usertam, could you nixfmt this as well? |
Member
Author
It will turn into which looks kinda off... 😬 Do I still do it? |
Member
I agree, it doesn't look the best. I'm not sure if passing nixfmt is mandatory at this point, so if it isn't, then leaving as-is is probably fine. Either way, this bump/your changes work pass my testing too, so I'll give this a +1 from me, and await feedback from someone who knows more about nixfmt requirements. |
techknowlogick
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple version update and I reworked the
aws-lc-sysdeps. Should be less hacky than the last.Hopefully using
rustPlatform.fetchCargoVendorwill make auto-updates easier. I see it is already innix-update?Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.