Skip to content

bitwarden-desktop: 2024.12.0 -> 2024.12.1#373177

Merged
ck3d merged 1 commit intoNixOS:masterfrom
patka-123:push-onksvlzmwnvq
Jan 19, 2025
Merged

bitwarden-desktop: 2024.12.0 -> 2024.12.1#373177
ck3d merged 1 commit intoNixOS:masterfrom
patka-123:push-onksvlzmwnvq

Conversation

@patka-123
Copy link
Contributor

@patka-123 patka-123 commented Jan 12, 2025

release notes: https://github.com/bitwarden/clients/releases/tag/desktop-v2024.12.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@patka-123 patka-123 marked this pull request as ready for review January 12, 2025 12:38
@patka-123 patka-123 requested a review from amarshall January 12, 2025 12:38
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 12, 2025
@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373177


x86_64-linux

✅ 1 package built:
  • bitwarden-desktop

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 12, 2025
@ck3d ck3d merged commit 8e0237b into NixOS:master Jan 19, 2025
59 of 61 checks passed
@patka-123 patka-123 deleted the push-onksvlzmwnvq branch January 19, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants