libgit2: 1.8.4 -> 1.9.0 (also pygit2 update)

[rhelmot]

Also includes a small configuration diff to get it to build on OpenBSD. I'll run nixpkgs-review overnight.

Changelog

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-openbsd (cross)
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[rhelmot]

nixpkgs-review is still running... there are 11 failures so far, most of which are projects that have libgit2 pinned to < 1.9.0... which is obviously concerning.

[rhelmot]

libgit2 seems to have introduced breaking changes this version, so this is gonna be a nasty upgrade...

[emilazy]

Pushed to:

• rebase on the merge base of staging and master for easier testing;
• fix the build on Darwin when using a case‐sensitive build directory;
• fix Nix and Jujutsu.

Will try another review with these fixes; hopefully it’ll be considerably more green.

[Mic92]

Nix side looks good to me.

[emilazy]

The actual regressions vs. master (other than GitButler) are:

✔  cargo-generate-0.22.1  2025-01-19  https://hydra.nixos.org/build/285731652
✔  edopro-application-40.1.4  2025-01-19  https://hydra.nixos.org/build/285667490
✔  gex-0.6.4  2025-01-20  https://hydra.nixos.org/build/285808304
✔  git-mit-5.14.3  2025-01-19  https://hydra.nixos.org/build/285787901
✔  git-warp-time-0.8.4  2025-01-19  https://hydra.nixos.org/build/285745844
✔  guile-git-0.9.0  2025-01-20  https://hydra.nixos.org/build/285782126
✔  guix-1.4.0  2025-01-20  https://hydra.nixos.org/build/285738832
✔  nix-init-0.3.2  2025-01-19  https://hydra.nixos.org/build/285739351
✔  poac-0.10.1  2025-01-19  https://hydra.nixos.org/build/285681930
✔  snapcraft-8.5.1  2025-01-22  https://hydra.nixos.org/build/286309123

I’ll try to take a look at these tonight.

[rhelmot]

edo9300/edopro#284 legitimate failure from upstream with no patch available for edopro-application.

[emilazy]

snapcraft was apparently a transient failure. I believe the only remaining regressions are nix-init (waiting on nix-community/nix-init#589) and gitbutler (waiting on #282798), so this should be as ready as it’ll ever be. Upstreaming the guile-git changes is pending figuring out what happened to my GitLab account…

[rhelmot]

also poac, which was renamed to cabinpkg on master, should be fixed with #376011

[rhelmot]

rebased on top of staging to resolve conflicts with #376038 and friends. running review now. I'm going to suggest that we've done enough work to mitigate fallout from this upgrade and we should merge.

[emilazy]

Agreed, doesn’t seem like a nix-init update is going to happen before this is merged.

Did you regenerate the changed cargoHashes after rebase (since useFetchCargoVendor uses a different scheme)? Sadly a review won’t catch that if you have the previous FODs cached…

[emilazy]

Confirmed hashes were regenerated, merging!