lmstudio: 0.3.5 -> 0.3.6

[crertel]

Updates to 0.3.6 rev 8.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[crertel]

Works on Linux, tested via nixpkgs-review pr 372738.

[crertel]

@NixOS/nixpkgs-merge-bot merge

[nixpkgs-merge-bot]

@crertel merge not permitted (#305350):
CommitterPR: pr author is not committer
R-Ryantm Maintainer merge: pr author is not r-ryantm

[crertel]

D'oh. @eeedean I forgot that the mergebot isn't working. Can you kick the tires on this for mac?

[eeedean]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372738

---

aarch64-darwin

❌ 1 package failed to build:

• lmstudio

---

I'm kinda puzzled, that's not from this change, obviously:

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/jxpdx1rhwxnhxry1gqlg3cqxny08jv1v-LM-Studio-0.3.6-8-arm64.dmg
error: only HFS file systems are supported.
do not know how to unpack source archive /nix/store/jxpdx1rhwxnhxry1gqlg3cqxny08jv1v-LM-Studio-0.3.6-8-arm64.dmg

[eeedean]

Looks like LM Studio did a thing. DMGs may be HFS or APFS and undmg only supports HFS.

I'm trying to provide a fix.

[crertel]

Bless 🙏

[drupol]

Should we wait for the fix or... ?

[eeedean]

Should we wait for the fix or... ?

It wouldn't build on darwin. Using 7zz results in a corrupted App Bundle on macOS, which wont start.

It's unfortunate, but I think, we should wait for a fix. Who really needs the most recent version (on Linux anyways), might be fine with overriding the src in an Overlay imho.

[eeedean]

I'm honestly not entirely sure about my proposed solution, but first the issues:
7zz does not work well with signed (notarized) App Bundles. It seems to mess up the Structure entirely and does not add the required xattr.
See the brief diff, I created from comparing dmg extracted by 7zz x LM\ Studio.app and using the Finder, which invokes native handling (mounting and opening a finder and then copying by drag'n'drop):
diff.txt
That's off and I cannot tell, if we can do a smart thing to make it work.

Anway: Insomnia.app seems to have had a similar challenge and they went as you can see here. They are invoking /usr/bin/hdiutil for mounting the dmg and then copy the binary from there. I'm not a big fan of that, but it works.

My proposed change (for darwin.nix):

  # LM Studio ships Scripts inside the App Bundle, which may be messed up by standard fixups
  dontFixup = true;

  # undmg doesn't support APFS and 7zz does break the xattr. Took that approach from https://github.com/NixOS/nixpkgs/blob/a3c6ed7ad2649c1a55ffd94f7747e3176053b833/pkgs/by-name/in/insomnia/package.nix#L52
  unpackCmd = ''
    echo "Creating temp directory"
    mnt=$(TMPDIR=/tmp mktemp -d -t nix-XXXXXXXXXX)
    function finish {
      echo "Ejecting temp directory"
      /usr/bin/hdiutil detach $mnt -force
      rm -rf $mnt
    }
    # Detach volume when receiving SIG "0"
    trap finish EXIT
    # Mount DMG file
    echo "Mounting DMG file into \"$mnt\""
    /usr/bin/hdiutil attach -nobrowse -mountpoint $mnt $curSrc
    # Copy content to local dir for later use
    echo 'Copying extracted content into "sourceRoot"'
    cp -a $mnt/LM\ Studio.app $PWD/
  '';

How do you feel about that?

[crertel]

Sounds like a plan! Want me to add that to this PR and squash it in if you can verify that it would work?

[eeedean]

Yes, please -- If there are no objections, may that's the way for now.

[crertel]

Alright @eeedean , should be good to try again.

[eeedean]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372738

---

aarch64-darwin

✅ 1 package built:

• lmstudio

Let's go! :)