nixos-option: move shellcheck validation to passthru.tests.shellcheck

[misuzu]

Fixes eval for riscv64-linux, see #369151 (comment)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[ElvishJerricco]

huh, almost feels like there should be a shellcheck hook or something that does this logic automatically. Oh well; probably not worth bothering over.

[lf-]

tryEval is evil, can we consider not doing this if possible? e.g. ensuring that the ghc/shellcheck is marked unavailable as appropriate?

[misuzu]

Unfortunately this is the only way it works, see #231537 (comment)

[Mic92]

@misuzu it would be useful if we would not need ghc as a build dependency in general to build nixos-option.
Could you just move the check to passthru.tests instead? Than we also don't need the complex testing logic.

[misuzu]

Could you just move the check to passthru.tests instead? Than we also don't need the complex testing logic.

Done

That part is gone.

[Mic92]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372722

---

x86_64-linux

✅ 2 packages built:

• home-manager
• nixos-option