Skip to content

Comments

pocket-casts: update electron pin; move to pkgs/by-name/#372095

Merged
emilylange merged 2 commits intoNixOS:masterfrom
yayayayaka:pocket-casts-bump-electron-version
Jan 11, 2025
Merged

pocket-casts: update electron pin; move to pkgs/by-name/#372095
emilylange merged 2 commits intoNixOS:masterfrom
yayayayaka:pocket-casts-bump-electron-version

Conversation

@yayayayaka
Copy link
Member

Electron 31 will be end-of-life soon, as per release timeline.

Part of #370758

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 8, 2025
@yayayayaka yayayayaka force-pushed the pocket-casts-bump-electron-version branch from 81b2175 to 7409d56 Compare January 8, 2025 11:29
@yayayayaka yayayayaka changed the title pocket-casts: update pinned electron version pocket-casts: update electron pin; move to pkgs/by-name/ Jan 8, 2025
@emilylange emilylange merged commit c3c9b28 into NixOS:master Jan 11, 2025
31 of 34 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 11, 2025

Successfully created backport PR for release-24.11:

@yayayayaka yayayayaka deleted the pocket-casts-bump-electron-version branch January 14, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants