Skip to content

nixos-option: drop dependency on git#371835

Merged
thiagokokada merged 1 commit intoNixOS:masterfrom
Mic92:nixos-option-perlless
Jan 8, 2025
Merged

nixos-option: drop dependency on git#371835
thiagokokada merged 1 commit intoNixOS:masterfrom
Mic92:nixos-option-perlless

Conversation

@Mic92
Copy link
Copy Markdown
Member

@Mic92 Mic92 commented Jan 7, 2025

Things done

Just realized that git would be an issue for the perlless profile.

Related to #369151

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 7, 2025
@nix-owners nix-owners bot requested review from Aleksanaa, FireyFly and azuwis January 7, 2025 15:41
@Mic92 Mic92 force-pushed the nixos-option-perlless branch from bfd9af8 to cb4072b Compare January 7, 2025 16:07
@lf- lf- changed the title nixos-option: replace git with gitMinimal nixos-option: drop dependency on git Jan 7, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 7, 2025
@thiagokokada thiagokokada merged commit e88e048 into NixOS:master Jan 8, 2025
0 of 4 checks passed
@Mic92 Mic92 deleted the nixos-option-perlless branch January 8, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants