webcord: 4.10.2 -> 4.10.3

[fccapria]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[NotAShelf]

Do you think you could also look into bumping the electron version?

[fccapria]

Do you think you could also look into bumping the electron version?

Sure, do you mean to the base electron version (33.3.0)?

[NotAShelf]

Webcord usually doesn't play nicely with the latest electron version, but since 31 is EOL soon switching to at least electron 32 would be nice.

[fccapria]

Webcord usually doesn't play nicely with the latest electron version, but since 31 is EOL soon switching to at least electron 32 would be nice.

I'm sorry, I can't understand: in the pkgs/top-level/all-packages.nix electron already corresponds to version 32. What should I do?

[NotAShelf]

Apologies, I've assumed that our electron was out of date based on #370758 (comment)

If you could spare the time, please try electron 33 - it would not hurt to update in advance. If not, I'll approve the package bump.

[fccapria]

Don't worry!
I just built webcord with electron 33 and it seems to have no problems. Maybe I'll continue using it until tonight or tomorrow morning and if it has no problems I'll update it to electron 33 :)

[fccapria]

@NotAShelf It seems to work without any problems.
I just bumped the electron version :)

[nixpkgs-ci]

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-371819-to-release-24.11 origin/release-24.11
cd .worktree/backport-371819-to-release-24.11
git switch --create backport-371819-to-release-24.11
git cherry-pick -x ea2ecb7b18f65bf3c7e7f976d79a84b4ba8472ec

[emilylange]

Please fix this in a follow-up PR and make sure to backport both this PR here and the follow-up PR.

electron_31 will be marked as insecure/EOL on release-24.11 as well not just unstable.

If you don't want to backport, that's fine as well and up to you to decide.
Just note that users will be presented with the error outlined in #370758 and then have to explicitly opt-into the EOL electron_31.

[emilylange]

As per #370758 (comment), this should have been

{ electron = electron_33; };

[emilylange]

And the actual package flagged and affected by #370758 isn't webcord, it's webcord-vendord.

webcord was already at electron_32, which won't be EOL for another two months or so.

webcord-vendord on the other hand is still at electron_31.

[NotAShelf]

I'll handle the fix shortly, might need help with the backport since I've never done tjat before.

[nixpkgs-ci]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] webcord: 4.10.2 -> 4.10.3 #375190