Skip to content

wavelog: init at 1.9.1#371658

Merged
NickCao merged 1 commit intoNixOS:masterfrom
ethancedwards8:wavelog-init
Jan 12, 2025
Merged

wavelog: init at 1.9.1#371658
NickCao merged 1 commit intoNixOS:masterfrom
ethancedwards8:wavelog-init

Conversation

@ethancedwards8
Copy link
Member

@ethancedwards8 ethancedwards8 commented Jan 7, 2025 •
edited
Loading

Init wavelog, an amateur radio logging application.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 7, 2025
@ethancedwards8
Copy link
Member Author

ethancedwards8 commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371658

aarch64-darwin

✅ 1 package built:
  • wavelog

@ethancedwards8
Copy link
Member Author

ethancedwards8 commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371658

x86_64-linux

✅ 1 package built:
  • wavelog

NickCao
NickCao reviewed Jan 7, 2025
View reviewed changes
@lucasew
Copy link
Contributor

lucasew commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371658

x86_64-linux

✅ 1 package built:
  • wavelog

lucasew
lucasew reviewed Jan 9, 2025
View reviewed changes
lucasew
lucasew reviewed Jan 9, 2025
View reviewed changes
lucasew
lucasew reviewed Jan 9, 2025
View reviewed changes
lucasew
lucasew reviewed Jan 9, 2025
View reviewed changes
lucasew
lucasew reviewed Jan 9, 2025
View reviewed changes
@ethancedwards8 ethancedwards8 mentioned this pull request Jan 12, 2025
Open
@Shawn8901 Shawn8901 removed their request for review January 12, 2025 17:18
NickCao
NickCao reviewed Jan 12, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these two nitpicks LGTM.

@ethancedwards8
wavelog: init at 1.9.1
8d54739 
Init wavelog, an amateur radio logging application.

Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
@NickCao NickCao merged commit 92e3a77 into NixOS:master Jan 12, 2025
21 checks passed
@HB9HIL HB9HIL mentioned this pull request Aug 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao approved these changes

@lucasew lucasew Awaiting requested review from lucasew

+1 more reviewer

@Shawn8901 Shawn8901 Shawn8901 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ethancedwards8 @lucasew @Shawn8901 @NickCao