Skip to content

Comments

heroic: update pinned electron version#370785

Merged
emilylange merged 1 commit intoNixOS:masterfrom
aidalgol:heroic-electron-update
Jan 4, 2025
Merged

heroic: update pinned electron version#370785
emilylange merged 1 commit intoNixOS:masterfrom
aidalgol:heroic-electron-update

Conversation

@aidalgol
Copy link
Contributor

@aidalgol aidalgol commented Jan 4, 2025

Things done

The pinned version of Electron that Heroic uses is soon to be EOL (#370758), so bump to the next oldest version.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 4, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 4, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 4, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370785


x86_64-linux

✅ 2 packages built:
  • heroic
  • heroic-unwrapped

@emilylange emilylange merged commit 06c2510 into NixOS:master Jan 4, 2025
23 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 4, 2025

Successfully created backport PR for release-24.11:

@aidalgol aidalgol deleted the heroic-electron-update branch January 8, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants