treewide: replace direct PR references to commits in patches

[PerchunPak]

If PR change, the patch will fail with hash mismatch.

Found using rg 'url ?= ?"https://github.com/.+/pull/\d+.(diff|patch)"'

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[PerchunPak]

Apparently this PR did change, I hope this doesn't break anything

[PerchunPak]

Oh nixpkgs no longer ships anything older 1.2, I remove it then

[PerchunPak]

The hash didn't change

$ nix hash to-sri --type sha256 1bwivimpi2hiil3zdnl5qkds1inyn239wgxbn3y8l2pwyppnnfl0
sha256-gDpr7/X8Cor8sKs/noaw3sag28SF2vYHjRGKeGvcka8=

[PerchunPak]

5c5
< @@ -105,6 +105,15 @@ media_output_dri_init (VADriverContextP ctx)
---
> @@ -105,6 +105,15 @@
21c21
< @@ -112,6 +121,7 @@ media_output_dri_init (VADriverContextP ctx)
---
> @@ -112,6 +121,7 @@

[PerchunPak]

Built krun, redis, vaapi-intel-hybrid, python311Packages.tpm2-pytss, python312Packages.tpm2-pytss, python313Packages.tpm2-pytss and everything is good (other packages are marked as broken)

The CI fails because of #370456

[lucasew]

Please add the PR link as comments on the patches for reference

[emilazy]

This is not really sufficient because GitHub will GC the old commits. The only truly safe way to vendor active PRs is to vendor the patches in tree.

(fetchpatch2 without ?full_index=1 is also a reproducibility issue because it does not filter out the index … lines that vary with repository size.)

[PerchunPak]

This is not really sufficient because GitHub will GC the old commits. The only truly safe way to vendor active PRs is to vendor the patches in tree.

In that case, the best solution would be to download patches from cache and vendor it. This PR prevents random hash failures if someone does a mass rebuild of fetchpatch*

[PerchunPak]

I gave up on creating full_index treewide, here is my take on this if someone wants to try:

rg -HIl fetchpatch2 | xargs -I{} perl -0777 -i -pe 's/(fetchpatch2(?:.*\n.*)+url ?= ?".*github[^"]*)(")/$1?full_index=1$2/g' {}

False positives are:

• It doesn't detect if full_index is already present
• It works on fetchurl

I gave up after seeing those two

[PerchunPak]

Looks like there is no interest in reviewing this, so I will just close it