Skip to content

postgresql: add doc/man outputChecks for all versions#370714

Merged
wolfgangwalther merged 1 commit intoNixOS:stagingfrom
wolfgangwalther:postgresql-output-checks
Jan 4, 2025
Merged

postgresql: add doc/man outputChecks for all versions#370714
wolfgangwalther merged 1 commit intoNixOS:stagingfrom
wolfgangwalther:postgresql-output-checks

Conversation

@wolfgangwalther
Copy link
Contributor

As discussed in #368091.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from Ma27 and thoughtpolice January 3, 2025 20:43
@github-actions github-actions bot added 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 3, 2025
@wolfgangwalther wolfgangwalther force-pushed the postgresql-output-checks branch from 38f70ac to 06c4971 Compare January 3, 2025 20:50
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #368091, I'm not sure I follow the reasoning here.

@wolfgangwalther wolfgangwalther force-pushed the postgresql-output-checks branch from 06c4971 to cb4b0fd Compare January 4, 2025 14:00
@wolfgangwalther
Copy link
Contributor Author

As mentioned in #368091, I'm not sure I follow the reasoning here.

As discussed over there - it won't really help with the outputChecks bug, but having more outputChecks is also not a bad thing... so merging!

@wolfgangwalther wolfgangwalther merged commit 10ba47d into NixOS:staging Jan 4, 2025
21 checks passed
@wolfgangwalther wolfgangwalther deleted the postgresql-output-checks branch January 4, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants