Skip to content

Conversation

@erictapen
Copy link
Member

Changelog: https://gitlab.com/yaal/canaille/-/blob/0.0.57/CHANGES.rst

Things done

Packages added:

  • otpauth
  • scim2-client
  • scim2-models
  • scim2-server
  • scim2-server

Pinging canaille maintainer @azmeuk

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 3, 2025
@nix-owners nix-owners bot requested a review from natsukium January 3, 2025 13:40
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am the maintainer of the python-scim collection too, so if you need help for this, let me know.

@azmeuk
Copy link

azmeuk commented Jan 3, 2025

I did not tested the changes, but by reading the diff, LGTM.

@lucasew
Copy link
Contributor

lucasew commented Jan 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370603


x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 16 packages built:
  • fdroidserver
  • fdroidserver.dist
  • gnome-secrets
  • mediamtx
  • python312Packages.libvirt
  • python312Packages.libvirt.dist
  • python312Packages.otpauth
  • python312Packages.otpauth.dist
  • python312Packages.zxcvbn-rs-py
  • python312Packages.zxcvbn-rs-py.dist
  • python313Packages.libvirt
  • python313Packages.libvirt.dist
  • python313Packages.otpauth
  • python313Packages.otpauth.dist
  • virt-manager
  • wesnoth

@erictapen
Copy link
Member Author

Oops, caused an eval error at first by misspelling maintainers

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 3, 2025
@erictapen erictapen removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jan 3, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 3, 2025
@fricklerhandwerk fricklerhandwerk merged commit f4a5e96 into NixOS:master Jan 29, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants