Skip to content

nixVersions.git: 2.25.0pre20241101_2e5759e3 -> 2.26.0pre20250102_deb3533e#370305

Closed
PerchunPak wants to merge 1 commit intoNixOS:masterfrom
PerchunPak:nix-fix-git
Closed

nixVersions.git: 2.25.0pre20241101_2e5759e3 -> 2.26.0pre20250102_deb3533e#370305
PerchunPak wants to merge 1 commit intoNixOS:masterfrom
PerchunPak:nix-fix-git

Conversation

@PerchunPak
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jan 2, 2025
@PerchunPak PerchunPak changed the title nixVersions.git: 2.25.0pre20241101_2e5759e3 -> 2.25.0pre20250102_deb3533e nixVersions.git: 2.25.0pre20241101_2e5759e3 -> 2.26.0pre20250102_deb3533e Jan 2, 2025
@PerchunPak
Copy link
Member Author

I found out that tests were disabled and actually fail. Will do some improvements and undraft it

@PerchunPak PerchunPak marked this pull request as draft January 2, 2025 19:13
@PerchunPak
Copy link
Member Author

I give up.

There are two tests failing: nix_api_expr_test.nix_build_drv and nix_api_expr_test.nix_expr_realise_context, logs:

building '/build/tests_nix-store.ue3K4P/my_nix_store/bkbxcbv30qygsvgyn40wx17sz5prmasn-myname.drv'...
error: executing '/bin/sh': No such file or directory
building '/build/tests_nix-store.0oRhWQ/my_nix_store/jz2psda3x8nrvp76rj48arkqwvrkmwyf-letsbuild.drv'...
error: executing '/bin/sh': No such file or directory
building '/build/tests_nix-store.wVBXua/my_nix_store/6l41ljjkr8bkmfg8fy7jx9wm8dcglpws-letsbuild.drv'...
error: executing '/bin/sh': No such file or directory

Also ./result/bin includes tests

@PerchunPak PerchunPak closed this Jan 4, 2025
@PerchunPak PerchunPak deleted the nix-fix-git branch January 4, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants