Merged
Conversation
Currently ofborg does this, but there is actually no real reason this shouldn't be done by CI
github-actions
bot
added
the
6.topic: continuous integration
dasJ
force-pushed
the
feat/label-stdenv-rebuild
branch
from
e8c0d85 to
2c05e92
Compare
nix-owners
bot
requested review from
LeSuisse,
mweinelt,
philiptaron and
risicle
github-actions
bot
added
10.rebuild-darwin: 0
dasJ
added a commit
to NixOS/ofborg
that referenced
this pull request
Dec 29, 2024
Deprecated by NixOS/nixpkgs#369102
Member
Author
|
Related: NixOS/ofborg#700 |
dasJ
added a commit
to NixOS/ofborg
that referenced
this pull request
Dec 29, 2024
Deprecated by NixOS/nixpkgs#369102
RossComputerGuy
approved these changes
Dec 30, 2024
Member
RossComputerGuy
left a comment
RossComputerGuy
left a comment
There was a problem hiding this comment.
As someone from the stdenv team, I like this.
wegank
added
the
12.approvals: 1
dasJ
added a commit
to NixOS/ofborg
that referenced
this pull request
Dec 30, 2024
Deprecated by NixOS/nixpkgs#369102
getchoo
pushed a commit
to getchoo-contrib/nixpkgs
that referenced
this pull request
Jan 1, 2025
Currently ofborg does this, but there is actually no real reason this shouldn't be done by CI (cherry picked from commit 6d96c9a)
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ofborg does this, but there is actually no real reason this shouldn't be done by CI
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.