{luaPackages,vimPlugins}: update on 2024-12-28#368843
Merged
khaneliman merged 6 commits intoNixOS:masterfrom Dec 28, 2024
Merged
{luaPackages,vimPlugins}: update on 2024-12-28#368843khaneliman merged 6 commits intoNixOS:masterfrom
khaneliman merged 6 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: vim
nix-owners
bot
requested review from
GaetanLepage,
PerchunPak,
figsoda,
manveru,
mrcjkb and
rvolosatovs
github-actions
bot
added
10.rebuild-darwin: 1001-2500
khaneliman
commented
Dec 28, 2024
| }; | ||
|
|
||
| guard-nvim = super.guard-nvim.overrideAttrs { | ||
| nvimRequireCheck = "guard"; |
Contributor
Author
There was a problem hiding this comment.
Breaking release changes with no default module, letting auto discover find modules to test.
khaneliman
commented
Dec 28, 2024
|
|
||
| nvim-notify = super.nvim-notify.overrideAttrs { | ||
| # Optional fzf integration | ||
| nvimSkipModule = "notify.integrations.fzf"; |
Contributor
Author
There was a problem hiding this comment.
They added fzf integration support recently
Contributor
Author
|
Contributor
|
Contributor
|
Contributor
|
Contributor
|
Contributor
Author
|
Sorry didn't notice the openscad failure before I left. What's the error? |
ofborg
bot
added
10.rebuild-darwin: 501+
Contributor
Unrelated: |
PerchunPak
approved these changes
Dec 28, 2024
Member
PerchunPak
left a comment
PerchunPak
left a comment
There was a problem hiding this comment.
LGTM, though @r-ryanth would run the update in ~two days
Contributor
Author
Would fail probably though |
Member
|
Looking at the amount of rebuilds, it would probably open a PR to staging and skip nixpkgs-review |
Contributor
We had this conversation a few times already.
We have been merging such updates to |
Member
|
I agree with you. I'm not saying that we should target staging, I'm saying that @r-ryantm would target staging automatically. And we would probably end up rebasing it to master. |
Contributor
Oh sorry I misread you then. Yes the bot would have targeted |
Member
Note that it gets slower also by people merging such changes; you get there sooner at the expense of other PRs getting there slower. Our build farm is still mainly limited by rebuild count, not their complexity. (that can be surprising, I know, as it differs from what people experience locally) I see roughly one step per second in our metrics. This PR is 8k in total with additional 4k of "cached jobs", so I'd estimate that as 3–4h delay for the farm. Nothing terrible, but not negligible either. |
Contributor
Yes, I heard that the rebuild count was important too. What do you suggest for the long term ? Having those bumps on |
Member
|
Perhaps we could create a top 100 list by starts of our plugins, and update it in master. For everything else, we could do updates in staging. Or ditch the idea of packaging literally anything in nixpkgs, and have a requirement of > X stars. Everything else should go to a separate flake. |
Member
|
You don't need to split it out of nixpkgs. But a possible thing to consider is that not everything would get built by Hydra. (or the majority would go through staging) |
Contributor
Author
|
One of my plans was to try and pin as many packages to releases as we can. Not everything needs to be latest git commit. Just need to update the plugin updater for vim plugins. |
Member
You will regret touching that code, it is that bad... |
13 tasks
PerchunPak
added a commit
to PerchunPak/nixpkgs
that referenced
this pull request
Feb 2, 2025
Building generated plugin is really simple and its cost to serve from hydra greatly outcomes cost of locally building. This also allows us to merge big rebuilds, where each rebuild is fairly simple, to master without delaying next branch update by a few hours (see NixOS#368843 (comment))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
@GaetanLepage gonna see if its plugin related and test against this branch
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.