Skip to content

vimPlugins.{lightline-bufferline, nvim-nonicons}: fix nativeCheckInputs#367787

Merged
GaetanLepage merged 2 commits intoNixOS:masterfrom
khaneliman:checks
Dec 24, 2024
Merged

vimPlugins.{lightline-bufferline, nvim-nonicons}: fix nativeCheckInputs#367787
GaetanLepage merged 2 commits intoNixOS:masterfrom
khaneliman:checks

Conversation

@khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Dec 24, 2024

Things done

Accidentally disabled require check by removing it from nativeCheckInputs.
Follow up #367802

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: vim Advanced text editor label Dec 24, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 24, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367787


x86_64-linux

✅ 3 packages built:
  • vimPlugins.lightline-bufferline
  • vimPlugins.nvim-nonicons
  • vimPluginsUpdater

aarch64-linux

✅ 3 packages built:
  • vimPlugins.lightline-bufferline
  • vimPlugins.nvim-nonicons
  • vimPluginsUpdater

x86_64-darwin

✅ 3 packages built:
  • vimPlugins.lightline-bufferline
  • vimPlugins.nvim-nonicons
  • vimPluginsUpdater

aarch64-darwin

✅ 3 packages built:
  • vimPlugins.lightline-bufferline
  • vimPlugins.nvim-nonicons
  • vimPluginsUpdater

@GaetanLepage GaetanLepage merged commit 4dc5e9d into NixOS:master Dec 24, 2024
@khaneliman khaneliman deleted the checks branch December 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants