Skip to content

python312Packages.ffmpy: 0.4.0 -> 0.5.0#367775

Merged
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:bump-ffmpy-1734998561
Dec 26, 2024
Merged

python312Packages.ffmpy: 0.4.0 -> 0.5.0#367775
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:bump-ffmpy-1734998561

Conversation

@pbsds
Copy link
Member

@pbsds pbsds commented Dec 24, 2024

Diff: Ch00k/ffmpy@refs/tags/0.4.0...0.5.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review December 24, 2024 00:46
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 24, 2024
@@ -21,12 +21,12 @@ buildPythonPackage rec {
owner = "Ch00k";
repo = "ffmpy";
rev = "refs/tags/${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "refs/tags/${version}";
tag = version;

in case you want to use the new tag argument.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is toil. Perhaps i should script a well-tested treewide?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Dec 24, 2024
@pbsds
Copy link
Member Author

pbsds commented Dec 25, 2024

gradio is broken on master https://hydra.nixos.org/build/282676642

@pbsds pbsds merged commit b0abc14 into NixOS:master Dec 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants