Skip to content

fetch{gitlab,gitiles}: add tag argument#367322

Merged
philiptaron merged 3 commits intoNixOS:masterfrom
Bot-wxt1221:fetchgitlab
Dec 24, 2024
Merged

fetch{gitlab,gitiles}: add tag argument#367322
philiptaron merged 3 commits intoNixOS:masterfrom
Bot-wxt1221:fetchgitlab

Conversation

@Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Dec 22, 2024

CC #355973

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) label Dec 22, 2024
@nix-owners nix-owners bot requested a review from philiptaron December 22, 2024 08:07
@Bot-wxt1221 Bot-wxt1221 changed the title fetchgitlab: add tag argument fetch{gitlab,gitiles}: add tag argument Dec 22, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 22, 2024
@Bot-wxt1221 Bot-wxt1221 force-pushed the fetchgitlab branch 3 times, most recently from 4f2b030 to a48d39a Compare December 22, 2024 08:17
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4990

@philiptaron philiptaron merged commit c7b408f into NixOS:master Dec 24, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 24, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants