Skip to content

Revert "emacs30: add a patch to fix upstream bug 67916"#367297

Merged
jian-lin merged 1 commit intoNixOS:staging-nextfrom
linj-fork:pr/revert-emacs-67916
Dec 22, 2024
Merged

Revert "emacs30: add a patch to fix upstream bug 67916"#367297
jian-lin merged 1 commit intoNixOS:staging-nextfrom
linj-fork:pr/revert-emacs-67916

Conversation

@jian-lin
Copy link
Copy Markdown
Contributor

@jian-lin jian-lin commented Dec 22, 2024

This reverts commit 5514e1e.

This resolves conflicts between staging-next and master after #367148 is merged into master. In addition, this patch does not need to go through a staging cycle. We can reapply it directly to master and it will probably reach users sooner.

#367296 reapplies this patch to master.

ref: #361947

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This reverts commit 5514e1e.

This resolves conflicts between staging-next and master after NixOS#367148
is merged into master.  In addition, this patch does not need to go
through a staging cycle.  We can reapply it directly to master and it
will probably reach users sooner.
@github-actions github-actions bot added the 6.topic: emacs Text editor label Dec 22, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 22, 2024
@jian-lin jian-lin merged commit 4049747 into NixOS:staging-next Dec 22, 2024
@jian-lin jian-lin deleted the pr/revert-emacs-67916 branch December 22, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant