prepare for a swtich to libcardiacarrest#36657
Merged
7c6f434c merged 9 commits intoNixOS:masterfrom Mar 9, 2018
Merged
Conversation
GrahamcOfBorg
added
8.has: package (new)
Member
Author
|
@GrahamcOfBorg build apulse pamixer |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
oxij
force-pushed
the
pkgs/pre-cardiacarrest
branch
from
dac233d to
079bbd3
Compare
Member
Author
|
@GrahamcOfBorg build libcardiacarrest libpressureaudio |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Member
Author
|
Ok, so I didn't screw up any hashes. The firefoxes I did build and test locally. LGTM. |
oxij
force-pushed
the
pkgs/pre-cardiacarrest
branch
from
079bbd3 to
64e50c1
Compare
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
7c6f434c
reviewed
Mar 9, 2018
pkgs/misc/apulse/default.nix
Outdated
Member
There was a problem hiding this comment.
Shouldn't version gain a suffix in that case?
7c6f434c
reviewed
Mar 9, 2018
Member
There was a problem hiding this comment.
Could you please add a link to upstream (Mozilla) issue?
Member
Author
|
Shouldn't version gain a suffix in that case?
Well, probably. But I have no idea about the protocol here. Should I add a "+" there? Something else?
Could you please add a link to upstream (Mozilla) issue?
I have not reported it yet. I can move that patch back to the stash, if you feel uncomfortable about it. `libcardiacarrest` will handle it anyway.
|
Member
|
Re: version: I think a period (or maybe Re: Firefox: I don't want any resolution, I want a link to check a few months later. I.e. a minimal report — yours or preexisting — is enough, the upstream discussion can go with its own pace afterwards. |
This adds LOG_TO_STDERR support and uses it for tracing.
This is optional (`libcardiacarrest` has a workaround for this bug because there's `firefox-bin` that I can't fix), but with this applied things are a bit smoother.
oxij
force-pushed
the
pkgs/pre-cardiacarrest
branch
from
64e50c1 to
23e2ea9
Compare
Member
Author
|
Both done.
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Member
Author
|
And thanks!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Side-effect of me building everything with
libcardiacarrestinstead oflibpulseaudio(see #35374). This patchset continues adding new parts needed for the switch and fixing existing parts that would break after the switch. Also some OCD fixes.This part should not cause a mass rebuild.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)