Skip to content

yate: patch shebangs in configure#36651

Merged
Mic92 merged 2 commits intoNixOS:masterfrom
pbogdan:yate-shebangs
Mar 9, 2018
Merged

yate: patch shebangs in configure#36651
Mic92 merged 2 commits intoNixOS:masterfrom
pbogdan:yate-shebangs

Conversation

@pbogdan
Copy link
Member

@pbogdan pbogdan commented Mar 9, 2018

Motivation for this change

Avoid dependency on /bin/sh, otherwise the build may fail like so https://hydra.nixos.org/build/70734780/nixlog/2

/cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 9, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018

@GrahamcOfBorg build pbogdan

@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018

gosh...
@GrahamcOfBorg build yate

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m attribute 'pbogdan' in selection path 'pbogdan' not found

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: attribute ‘pbogdan’ in selection path ‘pbogdan’ not found

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: attribute 'pbogdan' in selection path 'pbogdan' not found

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘yate-5.4.2-1’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/misc/yate/default.nix:33 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018

@pbogdan can you add yourself to borg? NixOS/ofborg#100

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/jn7nhyw0r1isn5whw518ba4gyvvaz5w2-yate-5.4.2-1/lib/libyatejabber.so.5.4.2
shrinking /nix/store/jn7nhyw0r1isn5whw518ba4gyvvaz5w2-yate-5.4.2-1/lib/libyatesig.so.5.4.2
gzipping man pages under /nix/store/jn7nhyw0r1isn5whw518ba4gyvvaz5w2-yate-5.4.2-1/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/jn7nhyw0r1isn5whw518ba4gyvvaz5w2-yate-5.4.2-1/lib  /nix/store/jn7nhyw0r1isn5whw518ba4gyvvaz5w2-yate-5.4.2-1/bin 
patching script interpreter paths in /nix/store/jn7nhyw0r1isn5whw518ba4gyvvaz5w2-yate-5.4.2-1
/nix/store/jn7nhyw0r1isn5whw518ba4gyvvaz5w2-yate-5.4.2-1/share/yate/scripts/echo.sh: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/jn7nhyw0r1isn5whw518ba4gyvvaz5w2-yate-5.4.2-1/bin/yate-config: interpreter directive changed from " /bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-yate-5.4.2-1.drv-0 in /nix/store/jn7nhyw0r1isn5whw518ba4gyvvaz5w2-yate-5.4.2-1...
/nix/store/jn7nhyw0r1isn5whw518ba4gyvvaz5w2-yate-5.4.2-1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

./typedefs.h:104:2: error: #error Please add support for your architecture in typedefs.h
 #error Please add support for your architecture in typedefs.h
  ^~~~~
make[2]: *** [Makefile:260: audio/common/resampler/resampler.o] Error 1
make[2]: Leaving directory '/build/yate/libs/miniwebrtc'
make[1]: *** [Makefile:425: ../libs/miniwebrtc/libminiwebrtc.a] Error 2
make[1]: Leaving directory '/build/yate/modules'
make: *** [Makefile:185: modules] Error 2
builder for '/nix/store/ayqkwmba8nmk7128q3pdkkg0kncv5gn1-yate-5.4.2-1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/ayqkwmba8nmk7128q3pdkkg0kncv5gn1-yate-5.4.2-1.drv' failed

@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018

@pbogdan can you also disable aarch64 for this build.

doesn't build on aarch64-linux
@GrahamcOfBorg GrahamcOfBorg added the 8.has: clean-up This PR removes packages or removes other cruft label Mar 9, 2018
@pbogdan
Copy link
Member Author

pbogdan commented Mar 9, 2018

Done, kept i686-linux as it looks to build and run fine (tested locally).

@Mic92 Mic92 merged commit 342743c into NixOS:master Mar 9, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018

also backported in d2bf584 7b72d7f

@pbogdan
Copy link
Member Author

pbogdan commented Mar 9, 2018

Thank you!

@pbogdan pbogdan deleted the yate-shebangs branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants