Skip to content

[Backport release-24.11] chromium: fix read out of range on aarch64 16k pages builds #366033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilylange merged 1 commit into from
Dec 20, 2024
Merged

[Backport release-24.11] chromium: fix read out of range on aarch64 16k pages builds #366033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pkgs/applications/networking/browsers/chromium/common.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,22 @@ let
excludes = [ "base/allocator/partition_allocator/src/partition_alloc/*" ];
revert = true;
})
]
++ lib.optionals (chromiumVersionAtLeast "131" && stdenv.hostPlatform.isAarch64) [
# Reverts decommit pooled pages which causes random crashes of tabs on systems
# with page sizes different than 4k. It 'supports' runtime page sizes, but has
# a hardcode for aarch64 systems.
# https://issues.chromium.org/issues/378017037
(fetchpatch {
name = "reverted-v8-decommit-pooled-paged-by-default.patch";
# https://chromium-review.googlesource.com/c/v8/v8/+/5864909
url = "https://chromium.googlesource.com/v8/v8/+/1ab1a14ad97394d384d8dc6de51bb229625e66d6^!?format=TEXT";
decode = "base64 -d";
stripLen = 1;
extraPrefix = "v8/";
revert = true;
hash = "sha256-PuinMLhJ2W4KPXI5K0ujw85ENTB1wG7Hv785SZ55xnY=";
})
];

postPatch =
Expand Down