Skip to content

wyrd: fix build error with ncurses-6.0-abi5-compat#36544

Merged
dtzWill merged 1 commit intoNixOS:masterfrom
xeji:wyrd-fix-build
Mar 8, 2018
Merged

wyrd: fix build error with ncurses-6.0-abi5-compat#36544
dtzWill merged 1 commit intoNixOS:masterfrom
xeji:wyrd-fix-build

Conversation

@xeji
Copy link
Contributor

@xeji xeji commented Mar 8, 2018

Motivation for this change

fix build error caused by ncurses 5.0 -> 6.0-abi5-compat

/cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 8, 2018
@dtzWill
Copy link
Member

dtzWill commented Mar 8, 2018

@GrahamcOfBorg build wyrd

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

mv //nix/store/yp0nxx283hm6ch9m38n4mn916s9lb2w9-wyrd-1.4.6/bin/wyrd.opt //nix/store/yp0nxx283hm6ch9m38n4mn916s9lb2w9-wyrd-1.4.6/bin/wyrd
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yp0nxx283hm6ch9m38n4mn916s9lb2w9-wyrd-1.4.6
shrinking /nix/store/yp0nxx283hm6ch9m38n4mn916s9lb2w9-wyrd-1.4.6/bin/wyrd
gzipping man pages under /nix/store/yp0nxx283hm6ch9m38n4mn916s9lb2w9-wyrd-1.4.6/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yp0nxx283hm6ch9m38n4mn916s9lb2w9-wyrd-1.4.6/bin 
patching script interpreter paths in /nix/store/yp0nxx283hm6ch9m38n4mn916s9lb2w9-wyrd-1.4.6
checking for references to /tmp/nix-build-wyrd-1.4.6.drv-0 in /nix/store/yp0nxx283hm6ch9m38n4mn916s9lb2w9-wyrd-1.4.6...
/nix/store/yp0nxx283hm6ch9m38n4mn916s9lb2w9-wyrd-1.4.6

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘wyrd-1.4.6’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/tools/misc/wyrd/default.nix:20 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

mv //nix/store/76b1pb7kqgz7ja5mb76dci8nxi3sqk1y-wyrd-1.4.6/bin/wyrd.opt //nix/store/76b1pb7kqgz7ja5mb76dci8nxi3sqk1y-wyrd-1.4.6/bin/wyrd
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/76b1pb7kqgz7ja5mb76dci8nxi3sqk1y-wyrd-1.4.6
shrinking /nix/store/76b1pb7kqgz7ja5mb76dci8nxi3sqk1y-wyrd-1.4.6/bin/wyrd
gzipping man pages under /nix/store/76b1pb7kqgz7ja5mb76dci8nxi3sqk1y-wyrd-1.4.6/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/76b1pb7kqgz7ja5mb76dci8nxi3sqk1y-wyrd-1.4.6/bin
patching script interpreter paths in /nix/store/76b1pb7kqgz7ja5mb76dci8nxi3sqk1y-wyrd-1.4.6
checking for references to /build in /nix/store/76b1pb7kqgz7ja5mb76dci8nxi3sqk1y-wyrd-1.4.6...
/nix/store/76b1pb7kqgz7ja5mb76dci8nxi3sqk1y-wyrd-1.4.6

@dtzWill
Copy link
Member

dtzWill commented Mar 8, 2018

Thanks! Will pick to 18.03 shortly! 👍

@dtzWill dtzWill merged commit f468f35 into NixOS:master Mar 8, 2018
@xeji xeji deleted the wyrd-fix-build branch March 8, 2018 19:06
@vbgl
Copy link
Contributor

vbgl commented Mar 8, 2018

#36433 has been opened for a couple of days…

@xeji
Copy link
Contributor Author

xeji commented Mar 8, 2018

@vbgl sorry, my mistake, I missed that...

@dtzWill
Copy link
Member

dtzWill commented Mar 8, 2018

Eep! Will look at that shortly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants