Skip to content

ci/eval/compare: truncate step summary to 1024k#365366

Merged
infinisil merged 1 commit intoNixOS:masterfrom
Mic92:truncate-summaries
Dec 20, 2024
Merged

ci/eval/compare: truncate step summary to 1024k#365366
infinisil merged 1 commit intoNixOS:masterfrom
Mic92:truncate-summaries

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 15, 2024

Things done

if the document gets to long, we now just show statistics instead.
I tried to limit number of packages based on the document lenght, but jq is too limited as a language for that.

#355847

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Dec 15, 2024
@Mic92
Copy link
Member Author

Mic92 commented Dec 15, 2024

Test run: Mic92#44

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 15, 2024
@Mic92
Copy link
Member Author

Mic92 commented Dec 20, 2024

cc @infinisil

@infinisil infinisil merged commit 4fbf4bc into NixOS:master Dec 20, 2024
@Mic92 Mic92 deleted the truncate-summaries branch December 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants