Skip to content

Upgrade Nuget version from 2.8.5 to 3.4.3#36534

Merged
copumpkin merged 1 commit intoNixOS:masterfrom
codyleyu:master
Mar 8, 2018
Merged

Upgrade Nuget version from 2.8.5 to 3.4.3#36534
copumpkin merged 1 commit intoNixOS:masterfrom
codyleyu:master

Conversation

@codyleyu
Copy link
Contributor

@codyleyu codyleyu commented Mar 8, 2018

Motivation for this change

I want to pull in my binary dependencies with NuGet package restore, but NuGet 2.8.5 is too old and not compatible with some of the packages I'm attempting to restore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • [X ] macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Seems to work on macOS:
CodyYu:nixpkgs codyyu$ nix-build -A dotnetPackages.Nuget
/nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 8, 2018
@copumpkin
Copy link
Member

@GrahamcOfBorg build dotnetPackages.Nuget

Also, cc @obadz who has some experience with this stuff.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘mono-4.0.4.1’ in /var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/pkgs/development/compilers/mono/generic.nix:90 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.ProjectModel.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.Types.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.v2.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.v3.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.VisualStudio.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Repositories.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Resolver.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.RuntimeModel.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Versioning.pc
/nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.ProjectModel.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.Types.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.v2.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.v3.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.VisualStudio.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Repositories.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Resolver.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.RuntimeModel.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Versioning.pc
/nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3

@codyleyu
Copy link
Contributor Author

codyleyu commented Mar 8, 2018

linking issue #34976

@codyleyu codyleyu requested review from FRidh, edolstra and nbp as code owners March 8, 2018 18:09
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 8, 2018
@GrahamcOfBorg GrahamcOfBorg removed the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 8, 2018
@copumpkin
Copy link
Member

Looks good, thanks!

@copumpkin copumpkin merged commit 51954f1 into NixOS:master Mar 8, 2018
@copumpkin copumpkin mentioned this pull request Mar 8, 2018
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants