Skip to content

bitwarden-desktop: 2024.11.1 -> 2024.12.0#365238

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
dotlambda:bitwarden-desktop
Dec 15, 2024
Merged

bitwarden-desktop: 2024.11.1 -> 2024.12.0#365238
wolfgangwalther merged 1 commit intoNixOS:masterfrom
dotlambda:bitwarden-desktop

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Dec 14, 2024

Diff: bitwarden/clients@desktop-v2024.11.1...desktop-v2024.12.0

Changelog: https://github.com/bitwarden/clients/releases/tag/desktop-v2024.12.0

fixes #365161
cc @unhitched9271

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda requested a review from amarshall December 14, 2024 20:12
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 14, 2024
@ddogfoodd
Copy link
Contributor

ddogfoodd commented Dec 14, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365238

x86_64-linux

✅ 1 package built:
  • bitwarden-desktop

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 15, 2024
@ofborg ofborg bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 15, 2024
@wolfgangwalther wolfgangwalther merged commit 6977af3 into NixOS:master Dec 15, 2024
4 of 5 checks passed
@dotlambda dotlambda deleted the bitwarden-desktop branch December 15, 2024 19:16
@amarshall amarshall mentioned this pull request Jan 25, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarshall amarshall Awaiting requested review from amarshall

1 more reviewer

@ddogfoodd ddogfoodd ddogfoodd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update request: bitwarden-desktop 2024.11.1 → 2024.12.0

4 participants

@dotlambda @ddogfoodd @wolfgangwalther @wegank