vimPlugins: fix the case of nvimRequirecheck#365018
Merged
teto merged 1 commit intoNixOS:masterfrom Dec 13, 2024
Merged
Conversation
khaneliman
approved these changes
Dec 13, 2024
Contributor
khaneliman
left a comment
There was a problem hiding this comment.
Thanks for catching those
seems like several 'nvimRequirecheck' have been added instead of 'nvimRequireCheck' removed it for neotest-gtest since it makes the build fail apparently
7dd7ae1 to
aab014c
Compare
Member
Author
|
I had so I removed the check for neotest-gtest and it builds now. Dunno if it works but can't check. |
Member
Author
|
merging since it passes nixpkgs-review and needed for #364378 |
teto
added a commit
to teto/nixpkgs
that referenced
this pull request
Dec 13, 2024
seems like several 'nvimRequirecheck' have been added instead of 'nvimRequireCheck'. removed it for neotest-gtest since it makes the build fail apparently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems like several 'nvimRequirecheck' have been added instead of 'nvimRequireCheck'
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.