Skip to content

vimPlugins: fix the case of nvimRequirecheck#365018

Merged
teto merged 1 commit intoNixOS:masterfrom
teto:teto/fix-nvimRequirecheck
Dec 13, 2024
Merged

vimPlugins: fix the case of nvimRequirecheck#365018
teto merged 1 commit intoNixOS:masterfrom
teto:teto/fix-nvimRequirecheck

Conversation

@teto
Copy link
Member

@teto teto commented Dec 13, 2024

seems like several 'nvimRequirecheck' have been added instead of 'nvimRequireCheck'

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching those

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 13, 2024
seems like several 'nvimRequirecheck' have been added instead of 'nvimRequireCheck'

removed it for neotest-gtest since it makes the build fail apparently
@teto teto force-pushed the teto/fix-nvimRequirecheck branch from 7dd7ae1 to aab014c Compare December 13, 2024 21:10
@teto
Copy link
Member Author

teto commented Dec 13, 2024

I had

1 package failed to build:
vimPlugins.neotest-gtest

31 packages built:
vimPlugins.neo-tree-nvim vimPlugins.neotest vimPlugins.neotest-bash vimPlugins.neotest-dart vimPlugins.neotest-deno vimPlugins.neotest-dotnet vimPlugins.neotest-elixir vimPlugins.neotest-foundry vimPlugins.neotest-go vimPlugins.neotest-golang vimPlugins.neotest-gradle vimPlugins.neotest-haskell vimPlugins.neotest-java vimPlugins.neotest-jest vimPlugins.neotest-minitest vimPlugins.neotest-pest vimPlugins.neotest-phpunit vimPlugins.neotest-playwright vimPlugins.neotest-plenary vimPlugins.neotest-python vimPlugins.neotest-rspec vimPlugins.neotest-rust vimPlugins.neotest-scala vimPlugins.neotest-testthat vimPlugins.neotest-vitest vimPlugins.neotest-zig vimPlugins.noice-nvim vimPlugins.otter-nvim vimPlugins.quarto-nvim vimPlugins.vim-tabby vimPluginsUpdater

so I removed the check for neotest-gtest and it builds now. Dunno if it works but can't check.

@teto
Copy link
Member Author

teto commented Dec 13, 2024

merging since it passes nixpkgs-review and needed for #364378

@teto teto merged commit 5ec9ea5 into NixOS:master Dec 13, 2024
@teto teto deleted the teto/fix-nvimRequirecheck branch December 13, 2024 21:12
teto added a commit to teto/nixpkgs that referenced this pull request Dec 13, 2024
seems like several 'nvimRequirecheck' have been added instead of 'nvimRequireCheck'.

removed it for neotest-gtest since it makes the build fail apparently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants