Skip to content

ci/eval: Avoid noise for failing attribute evals#364565

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
tweag:less-attr-eval-noise
Dec 12, 2024
Merged

ci/eval: Avoid noise for failing attribute evals#364565
Mic92 merged 1 commit intoNixOS:masterfrom
tweag:less-attr-eval-noise

Conversation

@infinisil
Copy link
Member

@infinisil infinisil commented Dec 12, 2024

It's currently annoying to see the actual failure in the attrs step, because time -v displays like 20 lines, which get repeated, therefore requiring you to scroll up most of the time:
https://github.com/NixOS/nixpkgs/actions/runs/12290298121/job/34297218345#step:5:794

This commit fixes that by only displaying the most important stats, the same ones as the chunked system-specific evals.

Things done


This work is funded by Tweag and Antithesis

Add a 👍 reaction to pull requests you find important.

It's currently annoying to see the actual failure in the attrs step,
because `time -v` displays like 20 lines, which get repeated, therefore
requiring you to scroll up most of the time:
https://github.com/NixOS/nixpkgs/actions/runs/12290298121/job/34297218345#step:5:794

This commit fixes that by only displaying the most important stats, the
same ones as the chunked system-specific evals.
@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Dec 12, 2024
@infinisil infinisil mentioned this pull request Dec 12, 2024
@infinisil infinisil marked this pull request as ready for review December 12, 2024 11:59
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 12, 2024
@Mic92 Mic92 merged commit 2151ae2 into NixOS:master Dec 12, 2024
@infinisil infinisil deleted the less-attr-eval-noise branch December 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants