Skip to content

nixos/nezha: init#364156

Open
Moraxyc wants to merge 3 commits intoNixOS:masterfrom
Moraxyc:add-nezha-module
Open

nixos/nezha: init#364156
Moraxyc wants to merge 3 commits intoNixOS:masterfrom
Moraxyc:add-nezha-module

Conversation

@Moraxyc
Copy link
Member

@Moraxyc Moraxyc commented Dec 11, 2024 •
edited
Loading

Must be merge after #361515 (Done)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 11, 2024
@Moraxyc Moraxyc force-pushed the add-nezha-module branch 2 times, most recently from 9c19fb1 to 44688e6 Compare December 11, 2024 07:36
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 11, 2024
@Moraxyc Moraxyc marked this pull request as draft December 11, 2024 08:26
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 31, 2024
@Moraxyc Moraxyc removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Jan 17, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
@Moraxyc Moraxyc force-pushed the add-nezha-module branch from 05dd681 to c0df889 Compare March 4, 2025 10:17
@Moraxyc Moraxyc removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 4, 2025
@Moraxyc Moraxyc force-pushed the add-nezha-module branch 2 times, most recently from 72f95d8 to 5d41990 Compare March 5, 2025 23:23
@Moraxyc Moraxyc marked this pull request as ready for review March 7, 2025 08:51
@Moraxyc Moraxyc force-pushed the add-nezha-module branch 4 times, most recently from 4532e9d to c38783a Compare March 7, 2025 23:19
@Moraxyc Moraxyc mentioned this pull request Mar 16, 2025
Merged
This was referenced Mar 25, 2025
Merged
Merged
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@Moraxyc Moraxyc force-pushed the add-nezha-module branch from c38783a to 187f662 Compare April 5, 2025 10:28
@Moraxyc Moraxyc removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 5, 2025
@Moraxyc Moraxyc mentioned this pull request Apr 5, 2025
Merged
@Moraxyc Moraxyc force-pushed the add-nezha-module branch from 187f662 to 55f394b Compare April 7, 2025 09:06
@Moraxyc Moraxyc mentioned this pull request Apr 18, 2025
Merged
@Moraxyc Moraxyc mentioned this pull request May 14, 2025
Merged
@Moraxyc Moraxyc force-pushed the add-nezha-module branch 3 times, most recently from 4fb1276 to 536ff09 Compare May 24, 2025 09:58
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2025
@Moraxyc Moraxyc force-pushed the add-nezha-module branch from 536ff09 to 0430d06 Compare June 15, 2025 12:15
@Moraxyc Moraxyc removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 15, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 5, 2025
jackrosenberg
jackrosenberg approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@jackrosenberg jackrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small nitpicks, otherwise looks good! It's a shame this PR has been ignored for so long.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 28, 2025
@Moraxyc Moraxyc force-pushed the add-nezha-module branch from 0430d06 to e5029b4 Compare July 29, 2025 12:02
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 15, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 7, 2025
This was referenced Oct 7, 2025
Merged
Merged
@Moraxyc Moraxyc mentioned this pull request Oct 30, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jackrosenberg jackrosenberg jackrosenberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Moraxyc @jackrosenberg @wegank @h7x4