Skip to content

nixos-option: link to nixos test#363967

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:nixos-option
Dec 11, 2024
Merged

nixos-option: link to nixos test#363967
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:nixos-option

Conversation

@Mic92
Copy link
Copy Markdown
Member

@Mic92 Mic92 commented Dec 10, 2024

Things done

#363919

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 mentioned this pull request Dec 10, 2024
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 10, 2024
@Mic92 Mic92 requested review from a team and removed request for a team December 11, 2024 06:55
@Mic92
Copy link
Copy Markdown
Member Author

Mic92 commented Dec 11, 2024

This should be rather uncontroversial.

@Mic92 Mic92 merged commit 2bd5a84 into NixOS:master Dec 11, 2024
@Mic92 Mic92 deleted the nixos-option branch December 11, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant