Skip to content

Introduce script to automatically resolve conflicts after treewide changes (such as reformats)#363759

Merged
dasJ merged 1 commit intoNixOS:masterfrom
tweag:format-rebase
Jan 21, 2025
Merged

Introduce script to automatically resolve conflicts after treewide changes (such as reformats)#363759
dasJ merged 1 commit intoNixOS:masterfrom
tweag:format-rebase

Conversation

@infinisil
Copy link
Member

@infinisil infinisil commented Dec 9, 2024

Motivated by NixOS/nixfmt#159 and the treewide Nixpkgs reformatting.

Ping @NixOS/nix-formatting

Things done


This work is funded by Tweag and Antithesis

Add a 👍 reaction to pull requests you find important.

@infinisil infinisil marked this pull request as draft December 9, 2024 23:51
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 9, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-formatting-team-treewide-nixpkgs-formatting/56666/12

@infinisil infinisil force-pushed the format-rebase branch 2 times, most recently from 75b199f to df672c9 Compare January 16, 2025 00:48
@infinisil infinisil changed the title WIP: format rebase script Introduce script to automatically resolve conflicts after treewide changes (such as reformats) Jan 16, 2025
@infinisil infinisil marked this pull request as ready for review January 16, 2025 01:23
@infinisil infinisil requested a review from a team January 16, 2025 01:25
@infinisil infinisil force-pushed the format-rebase branch 2 times, most recently from 1c0b08f to 6ef1bde Compare January 16, 2025 01:28
@infinisil
Copy link
Member Author

Reviewed together in the Nix formatting team meeting with @0x4A6F, @dasJ and @Sereja313.

@dasJ dasJ merged commit 3425323 into NixOS:master Jan 21, 2025
25 of 27 checks passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2025-01-21/59183/1

@infinisil infinisil deleted the format-rebase branch January 22, 2025 19:29
@emilazy emilazy mentioned this pull request Jan 24, 2025
13 tasks
@jfly jfly moved this from Todo to Approved in Nix formatting Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

4 participants