oci-containers: consolidate capabilities interface#363574
Merged
benley merged 2 commits intoNixOS:masterfrom Dec 12, 2024
Merged
oci-containers: consolidate capabilities interface#363574benley merged 2 commits intoNixOS:masterfrom
benley merged 2 commits intoNixOS:masterfrom
Conversation
13 tasks
benley
reviewed
Dec 9, 2024
Member
|
I was initially opposed to this approach but now that I see it implemented it actually looks pretty reasonable. Let's see what others might have to say about it. |
Improved wording Co-authored-by: Benjamin Staffin <benley@zoiks.net>
Contributor
Author
roberth
approved these changes
Dec 9, 2024
Member
roberth
left a comment
There was a problem hiding this comment.
This matches what I had in mind in our discussion.
The behavior seems to be well covered by the tests, the documentation is clear, and it now supports overriding.
It also matches what Arion does (a docker compose wrapper), which is nice, and also means that it's a proven solution.
benley
approved these changes
Dec 10, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capAddandcapDropwere consolidated into a singlecapabilitiesoption.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.