lib: rename maintainers-list.nix into maintainers/maintainer-list.nix#36275
Merged
7c6f434c merged 2 commits intoNixOS:masterfrom Mar 6, 2018
Merged
lib: rename maintainers-list.nix into maintainers/maintainer-list.nix#362757c6f434c merged 2 commits intoNixOS:masterfrom
7c6f434c merged 2 commits intoNixOS:masterfrom
Conversation
Member
Author
|
The ofborg error is pretty interesting. What is this? I don't even. |
oxij
force-pushed
the
lib/maintainers-list
branch
3 times, most recently
from
86cc5c6 to
94453db
Compare
Member
|
Maybe it has something to do with the change to |
Member
Author
|
Nah, now it's bugs in derivations. Will fix one by one as obborg finds them. |
Member
|
Ah, but then this should be two PRs, really. |
Member
|
The error is on master, not on your branch. The original PR didn't pass checks, and ofborg doesn't handle it well when master is already broken. |
Member
Author
|
All the things evaluate here. @grahamc or @Profpatsch can you pick up two top commits from here to master? I will then rebase to clean this up to match the topic. |
oxij
force-pushed
the
lib/maintainers-list
branch
from
b166fa9 to
3521a52
Compare
Member
|
I pushed the last two, but I think you meant the last three? |
Member
Author
|
Rebased onto #36279. |
Member
Author
|
@grahamc Well, yes (I need to go to sleep ASAP, I guess). Anyway, this branch looks good to me. Waiting for ofborg. |
Member
Author
|
Yay! This now closes #36279, I guess. |
GrahamcOfBorg
added
10.rebuild-darwin: 0
Member
|
Okay, the broken evaluations have been fixed in #36279. |
oxij
force-pushed
the
lib/maintainers-list
branch
from
3521a52 to
4e06e9e
Compare
Member
Author
|
I wonder why it worked without f56dc5213adaa51c854b6889f77be40bc9ddf7a4.
|
GrahamcOfBorg
added
10.rebuild-linux: 0
oxij
force-pushed
the
lib/maintainers-list
branch
2 times, most recently
from
39ddf56 to
70fab9e
Compare
Member
Author
|
Updated a bit. Why? Because `find . -iname '*-list*.nix'` now shows this:
```
./maintainers/maintainer-list.nix
./lib/tests/modules/define-value-list.nix
./nixos/modules/module-list.nix
```
|
oxij
changed the title
oxij
force-pushed
the
lib/maintainers-list
branch
from
70fab9e to
0a0a5ed
Compare
Many commits unrelated to `lib` touch that file, this will make `git log ./lib` much saner. This is what I meant in NixOS#36119 (comment).
oxij
force-pushed
the
lib/maintainers-list
branch
from
0a0a5ed to
610b5b8
Compare
Member
Author
|
ping |
Member
|
@GrahamcOfBorg eval |
vcunat
pushed a commit
that referenced
this pull request
Mar 7, 2018
lib: rename maintainers-list.nix into maintainers/maintainer-list.nix (cherry picked from commit 1bd790d) The intention is to reduce conflicts during maintenance.
matthewbauer
added a commit
to matthewbauer/nixpkgs
that referenced
this pull request
Mar 18, 2018
dotlambda
pushed a commit
that referenced
this pull request
Mar 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much saner
git log ./lib.