[WIP]: turn eval and nixpkgs-vet into reusable workflow#362471
Closed
JohnRTitor wants to merge 1 commit intoNixOS:masterfrom
Closed
[WIP]: turn eval and nixpkgs-vet into reusable workflow#362471JohnRTitor wants to merge 1 commit intoNixOS:masterfrom
JohnRTitor wants to merge 1 commit intoNixOS:masterfrom
Conversation
Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
github-actions
bot
added
6.topic: policy discussion
JohnRTitor
commented
Dec 6, 2024
Comment on lines
+24
to
+35
| if: | | ||
| github.event_name == 'pull_request_target' || | ||
| ( | ||
| github.event_name == 'push' && ( | ||
| startsWith(github.ref, 'refs/heads/master') || | ||
| startsWith(github.ref, 'refs/heads/staging') || | ||
| startsWith(github.ref, 'refs/heads/release-') || | ||
| startsWith(github.ref, 'refs/heads/staging-') || | ||
| github.ref == 'refs/heads/haskell-updates' || | ||
| github.ref == 'refs/heads/python-updates' | ||
| ) | ||
| ) |
Member
Author
There was a problem hiding this comment.
This is really ugly. Humm, and eval seems to get skipped?
github-actions
bot
added
10.rebuild-darwin: 0
infinisil
reviewed
Dec 11, 2024
| eval: | ||
| uses: ./.github/workflows/eval.yml | ||
| needs: get-merge-commit | ||
| if: | |
Member
There was a problem hiding this comment.
Suggested change
| if: | | |
| if: > |
I hope it's not this, but it's the only thing I can think of right now. This will convert all newlines to spaces (see https://yaml-multiline.info/)
wegank
added
the
2.status: merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in #361494 (comment), this will reduce the noise caused by having separate get-merge-commit workflow calls.
Can be tested in JohnRTitor#2