Skip to content

workflows/eval: Add the step summary as a comment #360962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azuwis wants to merge 1 commit into from
Closed

workflows/eval: Add the step summary as a comment #360962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/eval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,3 +267,13 @@ jobs:
GH_TOKEN: ${{ github.token }}
REPOSITORY: ${{ github.repository }}
NUMBER: ${{ github.event.number }}

- name: Adding comments
Copy link
Member

@Mic92 Mic92 Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not so sure about comments here. This will be posted everytime someone pushes to a pull request and a new eval starts. This sounds noisy to me and makes long-running pull requests reviews hard to read. We mostly care for these changes if they are mass rebuilds and for that we have labels.

Copy link
Contributor Author

@azuwis azuwis Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about gh pr comment "$NUMBER" --edit-last --body-file comparison/step-summary.md?

It should post only 1 comment, and update it on every push.

if: ${{ github.event_name == 'pull_request_target' }}
run: |
# Add the step summary as a comment
gh pr comment "$NUMBER" --body-file comparison/step-summary.md
env:
GH_TOKEN: ${{ github.token }}
GH_REPO: ${{ github.repository }}
NUMBER: ${{ github.event.number }}