Skip to content

vimPlugins.tiny-devicons-auto-colors-nvim: init at 2024-08-23#360919

Merged
khaneliman merged 1 commit intoNixOS:masterfrom
khaneliman:tiny-devicons
Dec 4, 2024
Merged

vimPlugins.tiny-devicons-auto-colors-nvim: init at 2024-08-23#360919
khaneliman merged 1 commit intoNixOS:masterfrom
khaneliman:tiny-devicons

Conversation

@khaneliman
Copy link
Contributor

Things done

Created for nix-community/nixvim#2381

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: vim Advanced text editor label Dec 2, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 2, 2024
Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khaneliman
Copy link
Contributor Author

khaneliman commented Dec 2, 2024

It dependents on nvim-web-devicons https://github.com/rachartier/tiny-devicons-auto-colors.nvim/blob/a39fa4c92268832f6034306793b8acbfec2a7549/lua/tiny-devicons-auto-colors/config.lua#L125

We're not bundling that dependency anymore in vimPlugins. That's going to be a nativeCheckInput in #352277. But, since it's a pcall in an apply function it doesn't even matter there. Context: #358809 and #359307 (comment), pulling in certain dependencies that can be mocked by other plugins can cause issues for users so in matrix we talked about not including these automatically.

@PerchunPak
Copy link
Member

Oh, you're right. mini-icons mock nvim-web-devicons module so it is fully compatible with web-devicons

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 2, 2024
@khaneliman khaneliman merged commit 874d76b into NixOS:master Dec 4, 2024
@khaneliman khaneliman deleted the tiny-devicons branch December 4, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants