Skip to content

vimPlugins.wezterm-nvim: init at 2024-09-26#360822

Merged
khaneliman merged 1 commit intoNixOS:masterfrom
samos667:init-wezterm-nvim
Dec 1, 2024
Merged

vimPlugins.wezterm-nvim: init at 2024-09-26#360822
khaneliman merged 1 commit intoNixOS:masterfrom
samos667:init-wezterm-nvim

Conversation

@samos667
Copy link
Copy Markdown
Contributor

@samos667 samos667 commented Dec 1, 2024

Created for nix-community/nixvim#2597 . Tested on my env via samos667/nivis@15ed310#diff-cbf6f300dc2c874d85281d69b76107a1ea0ff415d2548078773fce518e9c0fba

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: vim Advanced text editor label Dec 1, 2024
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Dec 1, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 1, 2024
@samos667 samos667 changed the title vimPlugins.wezterm-nvim: init at 0.5.0 vimPlugins.wezterm-nvim: init at 2024-09-26 Dec 1, 2024
@khaneliman
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360822


x86_64-linux

✅ 2 packages built:
  • vimPlugins.wezterm-nvim
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.wezterm-nvim
  • vimPluginsUpdater

x86_64-darwin

✅ 2 packages built:
  • vimPlugins.wezterm-nvim
  • vimPluginsUpdater

aarch64-darwin

✅ 2 packages built:
  • vimPlugins.wezterm-nvim
  • vimPluginsUpdater

@PerchunPak
Copy link
Copy Markdown
Member

This dependents on wezterm here. We might start specifying runtimeDeps? (#358587)

@khaneliman
Copy link
Copy Markdown
Contributor

This dependents on wezterm here. We might start specifying runtimeDeps? (#358587)

Good point, might as well start including those, too.

@khaneliman
Copy link
Copy Markdown
Contributor

Going to merge, as is, sounds like #360800 (comment) his preference would be to not merge those changes, yet until #358587 is available.

@khaneliman khaneliman merged commit 01271ee into NixOS:master Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants