Skip to content

Comments

lnav: remove optional dependency on gpm on darwin#360350

Closed
sagikazarmark wants to merge 1 commit intoNixOS:masterfrom
sagikazarmark:fix-lnav-darwin
Closed

lnav: remove optional dependency on gpm on darwin#360350
sagikazarmark wants to merge 1 commit intoNixOS:masterfrom
sagikazarmark:fix-lnav-darwin

Conversation

@sagikazarmark
Copy link
Member

#357675 added a few optional dependencies, some of which (gpm to be exact) cannot be built on Darwin.

This PR removes those dependencies on Darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 30, 2024
@Atemu
Copy link
Member

Atemu commented Nov 30, 2024

This wasn't backlinked and isn't easy to discover but the fix for this is in #360350 already which will be merged shortly.

@Atemu Atemu closed this Nov 30, 2024
@sagikazarmark
Copy link
Member Author

#360350 is this PR

@sagikazarmark sagikazarmark deleted the fix-lnav-darwin branch November 30, 2024 13:25
@sagikazarmark
Copy link
Member Author

#349284 is the right one (for reference)

@Atemu
Copy link
Member

Atemu commented Nov 30, 2024

Sorry, copied the wrong URL ^^'

@sagikazarmark
Copy link
Member Author

No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants