ci/check-shell: only run if shell.nix or ./ci/** is changed#360249
ci/check-shell: only run if shell.nix or ./ci/** is changed#360249infinisil merged 1 commit intoNixOS:masterfrom
shell.nix or ./ci/** is changed#360249Conversation
saves a bit of CI time
github-actions
bot
added
6.topic: policy discussion
nix-owners
bot
requested review from
LeSuisse,
azuwis,
mweinelt,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
| pull_request_target: | ||
| paths: | ||
| - 'shell.nix' | ||
| - './ci/**' |
There was a problem hiding this comment.
| - './ci/**' | |
| - 'ci/**' |
All examples here do not include ./
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
There was a problem hiding this comment.
As long as it works, I don't think we should care about such nits :)
There was a problem hiding this comment.
./ci/** does not work in practice.
I opened 2 PRs in my own nixpkgs fork.
-
Edit
shell.nix: shell.nix: edit to trigger CI azuwis/nixpkgs#1 -
Edit
ci/default.nixci/default.nix: edit to trigger CI azuwis/nixpkgs#2
You can see in https://github.com/azuwis/nixpkgs/actions/workflows/check-shell.yml that only azuwis#1 trigger the check-shell workflow.
There was a problem hiding this comment.
Oh damn, good catch, I wouldn't have expected that!
3 participants
saves a bit of CI time
check triggered: Mic92#41
check skipped: Mic92#42
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.