cargo-{audit,c,clone}: migrate to new apple-sdk pattern#359737
Closed
al3xtjames wants to merge 10 commits intoNixOS:stagingfrom
Closed
cargo-{audit,c,clone}: migrate to new apple-sdk pattern#359737al3xtjames wants to merge 10 commits intoNixOS:stagingfrom
al3xtjames wants to merge 10 commits intoNixOS:stagingfrom
Conversation
Member
|
Can you check if the OpenSSL dependencies here can be conditioned on |
b613a2c to
9f96f73
Compare
Contributor
Author
|
Good point, it's optional for |
9f96f73 to
6353faf
Compare
6353faf to
a3f555f
Compare
a3f555f to
f79bffe
Compare
Contributor
|
After building for almost 5 hours, I aborted my build for this PR. |
f79bffe to
e054ad4
Compare
Contributor
Author
|
I retargeted this to staging due to the number of rebuilds. |
Contributor
|
Done in #398707 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by #354146.
While we're here, also migrate to
pkgs/by-nameand runnixfmt-rfc-style.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.