Skip to content

home-assistant-custom-components.philips_airpurifier_coap: init at 0.28.0, python3Packages.aioairctrl: init at 0.2.5 #359651

Merged
mweinelt merged 2 commits intoNixOS:masterfrom
justinas:philips-airpurifier-coap
Dec 11, 2024
Merged

home-assistant-custom-components.philips_airpurifier_coap: init at 0.28.0, python3Packages.aioairctrl: init at 0.2.5 #359651
mweinelt merged 2 commits intoNixOS:masterfrom
justinas:philips-airpurifier-coap

Conversation

@justinas
Copy link
Member

Adds the philips-airpurifier-coap Home Assistant custom component.

Manually confirmed that the integration works on my Home Assistant instance.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 27, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 28, 2024
@justinas justinas force-pushed the philips-airpurifier-coap branch from 5eb9aee to f1c28f1 Compare December 1, 2024 14:53
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 1, 2024
@justinas justinas force-pushed the philips-airpurifier-coap branch from f1c28f1 to b07825a Compare December 1, 2024 15:04
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 2, 2024
@justinas justinas marked this pull request as ready for review December 3, 2024 15:13
@nix-owners nix-owners bot requested review from mweinelt and natsukium December 3, 2024 15:15
@justinas
Copy link
Member Author

justinas commented Dec 3, 2024

Thanks for the suggestions, I've applied them. I actually initialized all of this using an older version of nix-init, before the update to these conventions.

@justinas justinas requested a review from mweinelt December 3, 2024 19:56
@mweinelt
Copy link
Member

mweinelt commented Dec 3, 2024

I assumed as much. The boilerplate looked too familiar.

Looks like you didn't push any changes yet?

@justinas justinas force-pushed the philips-airpurifier-coap branch from 2aa287b to 6d6b4af Compare December 11, 2024 12:56
@justinas
Copy link
Member Author

Looks like you didn't push any changes yet?

Weird, I did update and force-push. The branch itself showed the changes, but the PR did not. I'll chalk it up to GitHub weirdness.

In any case, I've rebased on master again.

@mweinelt
Copy link
Member

One last nit: The package set is called python3Packages, not pythonPackages (= python2Packages).

@justinas justinas force-pushed the philips-airpurifier-coap branch from 6d6b4af to 30380af Compare December 11, 2024 17:49
@justinas justinas changed the title home-assistant-custom-components.philips_airpurifier_coap: init at 0.28.0, pythonPackages.aioairctrl: init at 0.2.5 home-assistant-custom-components.philips_airpurifier_coap: init at 0.28.0, python3Packages.aioairctrl: init at 0.2.5 Dec 11, 2024
@justinas
Copy link
Member Author

One last nit: The package set is called python3Packages, not pythonPackages (= python2Packages).

Reworded 👍

@mweinelt mweinelt merged commit 2e261ac into NixOS:master Dec 11, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 11, 2024

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-359651-to-release-24.11 origin/release-24.11
cd .worktree/backport-359651-to-release-24.11
git switch --create backport-359651-to-release-24.11
git cherry-pick -x b7ee10f466147f486f7f08c46217688ae166b2f4 30380af03328c73d2ec04d683a2afbe9d33b925a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants