Closed
Conversation
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12.first-time contribution
Contributor
|
Can we maybe build this from source? https://nixos.org/manual/nixpkgs/stable/#javascript-buildNpmPackage |
ofborg
bot
added
8.has: package (new)
Author
Sorry for my late response, I've been really busy with end of year things. I'll take a look at building from source with the docs you shared, thanks for this! |
|
|
||
| else | ||
| throw "Unsupported platform: ${stdenv.hostPlatform.system}"; | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ autoPatchelfHook ]; |
Otherwise the binary will not run properly.
| doCheck = false; | ||
|
|
||
| unpackPhase = ":"; | ||
| configurePhase = ":"; |
Member
There was a problem hiding this comment.
Suggested change
| configurePhase = ":"; | |
| dontConfigure = true; |
| chmod +x $out/bin/${pname} | ||
| ''; | ||
|
|
||
| fixupPhase = ":"; |
Member
There was a problem hiding this comment.
Suggested change
| fixupPhase = ":"; |
This phase is crucial for binary packages.
| ''; | ||
|
|
||
| meta = with lib; { | ||
| description = "A headless CLI that provides a set of useful tools for interacting with Filen cloud storage securely"; |
Member
There was a problem hiding this comment.
Suggested change
| description = "A headless CLI that provides a set of useful tools for interacting with Filen cloud storage securely"; | |
| description = "CLI to interact with Filen cloud storage securely"; |
| license = licenses.agpl3Only; | ||
| mainProgram = "filen-cli"; | ||
| platforms = platforms.unix; | ||
| maintainers = [ maintainers.onahp ]; |
Member
There was a problem hiding this comment.
Suggested change
| maintainers = [ maintainers.onahp ]; | |
| maintainers = [ maintainers.onahp ]; | |
| sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ]; |
wegank
added
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
2.status: stale
Contributor
|
Done in #375965. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding filen command-line support
filen-clion NixOS. Have done tests on local machines regarding:$NIXPKGSexportThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.