gopass-jsonapi: 1.15.14 -> 1.15.15

[doronbehar]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[doronbehar]

How to choose the sdk version?

[emilazy]

The stdenv platform notes documentation has recommendations. But do you need anything at all here? It seems like the relevant file conditions on the minimum macOS version being targeted (somewhat incorrectly), so you should be able to just use the default and < ScreenCaptureKit/ScreenCaptureKit.h> won’t be included.

[doronbehar]

@emilazy Initially I didn't try to add anything Darwin specific, but I got build errors saying:

# github.com/kbinani/screenshot
vendor/github.com/kbinani/screenshot/darwin.go:9:10: fatal error: 'ScreenCaptureKit/ScreenCaptureKit.h' file not found
#include <ScreenCaptureKit/ScreenCaptureKit.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

How do you explain this?

[emilazy]

I guess the issue is that it conditions it on __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ > MAC_OS_VERSION_14_4, and maybe the undefined MAC_OS_VERSION_14_4 on our default SDK is defaulting to 0 or something? Anyway you can give it apple-sdk_14 and omit any darwinMinVersionHook.

[doronbehar]

OK thanks it worked. I wonder then, what does it mean to use darwinMinVersionHook along with a specific apple-sdk version? Why do we need the former if we are capable of choosing any of the later?

[emilazy]

apple-sdk_* determines what APIs are available, darwinMinVersionHook determines what is required at runtime. Some applications will use available APIs without conditioning on runtime availability and some (like this Go code) will only use APIs if they are available on the minimum version rather than checking for runtime availability, so we have both knobs. Usually you don’t want to adjust the darwinMinVersionHook unless you have to. See the docs and my longer‐form explanation if you want the algorithm I use for tricky cases (but in most cases you can follow the docs’ recommendation of “only do anything if the build breaks; if it does then use the lowest SDK that works; don’t do anything else”).

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/the-darwin-sdks-have-been-updated/55295/28

[doronbehar]

@NixOS/nixpkgs-vet could anyone explain the obscure nix formatting error here?

[doronbehar]

@NixOS/nixpkgs-vet could anyone explain the obscure nix formatting error here?

Can't reproduce the error anymore...