Make all version metadata fields configurable#358296
Make all version metadata fields configurable#358296Princemachiavelli wants to merge 1 commit intoNixOS:masterfrom
Conversation
Downstream users of NixOS may adapt it for their own products or distro variants. Customizing the version information is ideal so users of these downstream derivatives can see the correct branding, version, and lifecycle support dates of these derivative projects. Add options for SUPPORT_END and LOGO. Make release and codeName internal options instead of readOnly.
github-actions
bot
added
6.topic: nixos
|
This introduces the obvious problem of "well, what if I want to override something else, like Instead of making more and more options for each field in /etc/os-release, we can just override them. I have a PR open that does exactly that. |
|
|
||
| release = mkOption { | ||
| readOnly = true; | ||
| internal = true; |
There was a problem hiding this comment.
I'm very much against setting those options as not R/O. Downstreams know where to look and can override them, and there's no reason to have users editing internal distro branding options.
There was a problem hiding this comment.
Downstreams know where to look and can override them,
Am I misunderstanding something? internal omits the option from the manual while readOnly options are also cannot be overriden. Or is your point that such downstream use-cases must/ought fork nixpkgs and manually update the field? In any case, I agree is #351736 is a much better solution.
|
Closing in favor of #351736 |
2 participants
Downstream users of NixOS may adapt it for their own products or distro variants. Customizing the version information is ideal so users of these downstream derivatives can see the correct branding, version, and lifecycle support dates of these derivative projects. NixOS is an ideal platform for spin off distros like RedNixOS and NixNG and they can provide their own logo and EOL dates.
Add options for SUPPORT_END and LOGO os-release fields. Make release and codeName internal options instead of readOnly.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)